-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring project to modern day Rust WASM #15
Conversation
In particular: * Replace `stdweb` with `wasm-bindgen` and `web-sys` * Replace `cargo-web` with `trunk` * Set edition to 2021
Hey @alexschrod , sorry only just saw this. Looks great! Was the CNAME file intentionally removed? I think we'd still need that, unless github pages has changed without my realising. :) |
Oh, it looks like some other commits have since been added to the branch. Shall I undo those? |
Yeah, sorry, with your lack of response, I was in the middle of "going rogue" and decided to take things into my own hands, as I'd noticed you'd been fairly active on GitHub for days after I opened this PR, so I thought you weren't interested since you didn't respond. I can undo some of that if you're open to it after all. 😄 |
As for the CNAME, it should be added during the GH Action run. I can set that up, too. I was planning for you to move over to the new model of GH pages since it looks like you're on the very old one from back when they could only exist in a /docs folder under master. |
With this new change, I'll fix things up and let you know when it's ready for review again. 😄 |
No copyright assignment agreement exists in this repo; thus each individual contribution holds the copyright over each piece of their own code, so the copyright statement should reflect this. Also, the license should not be edit but be presented as is, verbatim. The notice example is a template for how to show it in a program, not one to be edited in the license.
(cherry picked from commit 7e209b5) # Conflicts: # src/main.rs
(cherry picked from commit c55e34e)
(cherry picked from commit fff58b8) # Conflicts: # src/main.rs
which is a lie, given that the code is AGPL licensed, which "gives up" a lot of the rights of "default" copyright.
Alright @lpil. This PR has gotten a bit bigger than originally intended since I "moved on" when I thought you weren't interested and started changing some things and adding some features that I wanted to add to my updated version. In addition to what I stated in the OP, the following things are now also part of this PR:
Alright. As for your confusion around the CNAME file, here's what you need to do. I think it might be best to do these bits BEFORE you accept the PR:
Alright! Once you've done this and AFTER you've accepted this PR and the CI has done its build and deployment successfully, you'll then want to go to your repo's pages configuration, and make changes so it looks like this: Alright. That should be everything. Let me know if you have any questions, concerns, comments or any other kind of feedback. I (or you) can set this PR to not be a draft and you can approve it once you're satisfied you're ready to accept it. |
Wonderful! Thank you very much for all this work, and your thorough write up. Super helpful 💜
Sorry, my inbox is just very busy 😅
I don't think that this isn't true. "all rights reserved" means the copyright holders have not waived their rights, it does not conflict with a licence which gives others certain rights also, rather AGPL relies upon copyright being held. |
Noice. 😄 Do you mind if I post about this update/upgrade in various places, like the Rust subreddit or the Rust users forum? Or would you like to do so yourself, perhaps? |
What a cracking idea. Please do go ahead @alexschrod ! I look forward to reading it. :) |
Hey @lpil. 👋
This regex tester tool of yours is used by a lot of people, but I couldn't help but notice it was just sitting there, sad and dilapidated, and I thought I'd help bring some life back into it!
In the process made some executive decisions that I'd like to run by you before I turn this into a non-draft pull request, so we're on the same page before anything happens. These are the changes I decided to go ahead and make (and of course you can also just look at the commits/file changes if that's more your style):
master
branch from under/docs
, it makes more sense for automatic deployment for it to happen from thegh-pages
branch at/
. So that's the approach I recommend you take, should you choose to move forward with this PR.stdweb
, which hasn't seen an update in over 3 years, and over towasm-bindgen
andweb-sys
, both actively maintained and the currently most appropriate crates for Rust/WASM<->JS interop, and replacedcargo-web
, which again, hasn't seen an update in over 3 years, withtrunk
, a modern WASM application bundler that makes working with Rust-for-WASM a breeze.main.rs
) and fixed anything about the code that was in violation of said lints.regex
to the latest version. Probably my least controversial decision tbh.Well, there you go; if you have any feedback, I'm very open to making adjustments.
While I'm at it, I'll also say that I'm willing to take over stewardship of this project, should you wish not to take on/keep the maintenance burden of the project; I'd even go so far as to take on the hosting burden (I mean, I'd still use GH pages for it, but I'd be willing to use a domain name under my control if you'd like.)