Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix #1296

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Nix #1296

merged 5 commits into from
Sep 4, 2024

Conversation

nim65s
Copy link
Collaborator

@nim65s nim65s commented Sep 4, 2024

@nim65s nim65s added the no changelog Disable Changelog check label Sep 4, 2024
cmastalli
cmastalli reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for supporting Nix, @nim65s!

Could you include the Nix installation instructions and badget in the Readme file?

@nim65s
Copy link
Collaborator Author

nim65s commented Sep 4, 2024

Done. While here, I'm also documenting the archlinux package.

cmastalli
cmastalli approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks!

Please be aware that ROS jobs are not passing due to Pinocchio, i.e., no need to wait for them.

@cmastalli cmastalli merged commit b979357 into devel Sep 4, 2024
8 of 10 checks passed
@cmastalli cmastalli deleted the nix branch September 4, 2024 21:02
@nim65s nim65s mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmastalli cmastalli cmastalli approved these changes

Assignees
No one assigned
Labels
no changelog Disable Changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nim65s @cmastalli