-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indexing complete #479
base: main
Are you sure you want to change the base?
Conversation
This is very useful. Please move this forward. Thanks |
Hi! Since I don't use any index lifecycle policy I would like to ask one thing just to understand: "Completed" indices are those that you want to hide by default (similar to what cerebro does with closed or internal indices) because the are already rolled over right? |
Hi Miguel,
Your understanding is correct. "indexing" completed means it is already rolled over so we can filter these out and focus on the indices that are active and indexing new documents.
Thanks,
--Larry
…________________________________
From: Miguel Olivares <[email protected]>
Sent: Thursday, October 1, 2020 8:13 AM
To: lmenezes/cerebro <[email protected]>
Cc: larryzhu2018 <[email protected]>; Comment <[email protected]>
Subject: Re: [lmenezes/cerebro] Add indexing complete (#479)
Hi!
Thanks for contributing. Code looks nice and UI looks good too.
Since I don't use any index lifecycle policy I would like to ask one thing just to understand: "Completed" indices are those that you want to hide by default (similar to what cerebro does closed or internal indices) because the are already rolled over right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flmenezes%2Fcerebro%2Fpull%2F479%23issuecomment-702204344&data=02%7C01%7C%7C270f5a72511f40abe09608d8661c7f90%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637371619868314646&sdata=WQZ%2BUZNyz09HJJGd7CtjJhhJrTuxMi%2BXUvhpJIW5GiE%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKTDZPDMPRRORDU2YWY5M3LSISMADANCNFSM4RU3GV5Q&data=02%7C01%7C%7C270f5a72511f40abe09608d8661c7f90%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637371619868324647&sdata=PXaMSKd6Z8D7%2Bin0WpqceSC4mv7UZiPm0GUE%2BVDeiCQ%3D&reserved=0>.
|
@moliware do you think this might be useful to more and worth merging? In our usecase it has proven to be very useful as we have a sizeable number of indices & with this we don't have to flick through a significant number of pages of them only to find those that are indexing new docs, like @larryzhu2018 mentioned |
yes, merge please, i have 3k indexes, about 50 per day, navigating is always a big pain |
This PR adds the ability to filter out the indices that are completed from those that aren't. For our usecases this helps reducing the sheer number of pages we need to scroll through and allows us to concentrate only on those indexes that are complete