Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lld on clang-aarch64-full-2stage #281

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use lld on clang-aarch64-full-2stage #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion buildbot/osuosl/master/config/builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,11 +453,12 @@
'NO_STOP_MESSAGE':'1', # For Fortran test-suite
},
testsuite_flags=[
'--cppflags', '-mcpu=cortex-a57',
'--cppflags', '-mcpu=cortex-a57 -fuse-ld=lld',
'--threads=32', '--build-threads=32'],
extra_cmake_args=[
"-DCMAKE_C_FLAGS='-mcpu=cortex-a57'",
"-DCMAKE_CXX_FLAGS='-mcpu=cortex-a57'",
"-DLLVM_ENABLE_LLD=True",
"-DLLVM_LIT_ARGS='-v'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should use -DCLANG_DEFAULT_LINKER=lld but I am little unsure about what -DLLVM_ENABLE_LLD=True does.
Also now that we are making changes to this builder, let change the cpu setting as well. I guess this will run on AWS which may use -mcpu=neoverse-v1 or something similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ampere Mountain Jade something but yes we should do that anyway I'll do that in a new PR.

"-DMLIR_INCLUDE_INTEGRATION_TESTS=True",
"-DMLIR_RUN_ARM_SVE_TESTS=True",
Expand Down