[CIR][CIRGen][Builtin][Neon] Lower vaddh_f16, vsubh_f16, vmulh_f16 and vdivh_f16
#1258
+713
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
…16` and `vdivh_f16`
AmrDeveloper
force-pushed
the
lower_vaddh_f16
branch
from
f038ee5 to
aa8fa6c
Compare
ghehg
reviewed
Jan 2, 2025
| // LLVM-LABEL: test_vmulh_f16 | ||
| // LLVM: [[MUL:%.*]] = fmul half [[A:%.*]], [[B:%.*]] | ||
| // LLVM: ret half [[MUL]] | ||
| float16_t test_vmulh_f16(float16_t a, float16_t b) { |
There was a problem hiding this comment.
Similar to this comment,
here [[A:%.]] and [[B:%.]] could come from func arg, or simply be replaced by %0 and %1.
ghehg
requested changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering:
vaddh_f16vsubh_f16vmulh_f16vdivh_f16