[CIR][CIRGen][Builtin][Neon] Lower neon_vaddd_s64 and neon_vaddd_u64
#1255
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghehg
reviewed
Jan 2, 2025
| // return vaddd_u64(a, b); | ||
| // } | ||
| // CIR-LABEL: vaddd_s64 | ||
| // CIR: [[v3:%.*]] = cir.binop(add, [[v1:%.*]], [[v2:%.*]]) : !s64i |
There was a problem hiding this comment.
since v3, v1, v2 are not referenced in later lines, we could just use
{{.*}} like in the test case of test_vaddvq_f64 in this test file.
ghehg
reviewed
Jan 2, 2025
| // CIR: [[v3:%.*]] = cir.binop(add, [[v1:%.*]], [[v2:%.*]]) : !s64i | ||
|
|
||
| // LLVM-LABEL: @test_vaddd_s64( | ||
| // LLVM: [[VADDD_I:%.*]] = add i64 [[a:%.*]], [[b:%.*]] |
There was a problem hiding this comment.
NIT
we could just add a line to make sure that a and b are actually arguments to the test function, like
`
// LLVM-LABEL: @test_vaddd_s64
// LLVM-SAME: (i64 [[a:%.]], i64 [[b:%.]])
or simply do [[VADDD_I:%.*]] = add i64 %0, %1` here.
Same comments for other test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering Neon
vaddd_s64andvaddd_u64