[CIR][CIRGen][Builtin][Neon] Lower neon_vset_lane_f64 #1253
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghehg
reviewed
Jan 2, 2025
| @@ -137,6 +137,18 @@ float32x4_t test_vsetq_lane_f32(float32_t a, float32x4_t b) { | |||
| // LLVM: [[INTRN_RES:%.*]] = insertelement <4 x float> [[B]], float [[A]], i32 3 | |||
| // LLVM: ret <4 x float> [[INTRN_RES]] | |||
|
|
|||
| float64x1_t test_vset_land_f64(float64_t a, float64x1_t b) { | |||
There was a problem hiding this comment.
is this a typo?
did you mean:
test_vset_lane_f64
ghehg
requested changes
Jan 2, 2025
AmrDeveloper
force-pushed
the
lower_neon_vset_lane_f64
branch
from
c9b0bb7 to
718ae57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering Neon
vset_lane_f64References:
Clang CGBuiltin Implementation
Builtin definition