[CIR][CIRGen][Builtin][Neon] Lower neon_vsetq_lane_f64 #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for working on it. |
ghehg
reviewed
Jan 2, 2025
| llvm_unreachable("NEON::BI__builtin_neon_vsetq_lane_f64 NYI"); | ||
| case NEON::BI__builtin_neon_vsetq_lane_f64: { | ||
| Ops.push_back(emitScalarExpr(E->getArg(2))); | ||
| Ops[1] = builder.createBitcast( |
There was a problem hiding this comment.
IMO
To reduce code duplication which OG had, We could consider extracting
`
Ops.push_back(emitScalarExpr(E->getArg(2)));
return builder.createcir::VecInsertOp(getLoc(E->getExprLoc()), Ops[1],
Ops[0], Ops[2]);
`
into a helper function in future case like this.
ghehg
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering Neon
vsetq_lane_f64References:
Clang CGBuiltin Implementation
Builtin definition