Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CombToAIG] Lower comb.icmp #8016

Merged
merged 5 commits into from
Jan 7, 2025
Merged

[CombToAIG] Lower comb.icmp #8016

merged 5 commits into from
Jan 7, 2025

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Dec 24, 2024

This commit adds a pattern for icmp. Lowering is straight-forward but fairly complicated. LEC is verified. Test is modified to run CSE for simplifying lit testing.

This commit adds a pattern to lower mul. Mul is lowered into chains of
comb.add + comb.mux

```
a_{n}a_{n-1}...a_0 * b
= sum_{i=0}^{n} a_i * 2^i * b
= sum_{i=0}^{n} (a_i ? b : 0) << i
This commit adds a pattern for icmp. Lowering is straight-forward
but fairly complicated. LEC is verified
@uenoku uenoku force-pushed the dev/hidetou/aig-comp branch from 9658cee to fb1c2a4 Compare December 24, 2024 08:39
Base automatically changed from dev/hidetou/comb-to-aig-mul-2 to main December 27, 2024 05:02
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat 😎

@uenoku uenoku merged commit f2da3b7 into main Jan 7, 2025
4 checks passed
@uenoku uenoku deleted the dev/hidetou/aig-comp branch January 7, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants