Support pulling mod by manifest hash #998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #922
Further work needed to support a wider range of formats for the mods as currently it only works with themods:tag@sha256:hash
format and notmods@sha256:hash
format.Benefits of this PR and context:
Given the following inputs for DOCKER_MODS:
The data is parsed as:
And then correctly fetched from the remote registry and saved as:
How Has This Been Tested?
Source / References:
Note that technically when supplying a SHA hash the tag is not used by the docker CLI, thus all of the following will result in the same image being fetched:
But from a mod perspective they're treated as 3 different mods because of how we store the data about them (Layer SHA, not manifest SHA).