Fixed nm.py crashing installer when network card id has special characters #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I was helping a relative install Linux mint 22 on their HP Victus computer, and the installer failed to launch no matter what we did. We eventually traced it down to the same issue that these people had on the forum: https://forums.linuxmint.com/viewtopic.php?t=429209. Their fix is relatively easy, just ignore any errors caused by special characters in the network card's ID, by adding
, errors='replace'to the Popen command in nm.py. By changing that line on the live install media, we were able to get the installer to launch and complete the installation process. All attribution goes to DNTRS, I am simply opening the pull request so that more people can enjoy this.