Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation for symfony/config 4.2 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix deprecation for symfony/config 4.2 #8

wants to merge 1 commit into from

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Nov 30, 2018

mhujer
mhujer commented Nov 30, 2018
View reviewed changes
DependencyInjection/Configuration.php
$treeBuilder = new TreeBuilder('lexik_data_layer');

if (method_exists($treeBuilder, 'getRootNode')) {
$rootNode = $treeBuilder->getRootNode();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the both ways of getting the root node here in case it is needed in the future.

@mhujer
Copy link
Contributor Author

mhujer commented Nov 30, 2018

Travis fail seem unrelated (PHP 5.6 runs out of memory)

@mhujer
Copy link
Contributor Author

mhujer commented Dec 18, 2018

@slashfan any chance to get this merged?

@mhujer
Copy link
Contributor Author

mhujer commented Apr 2, 2019

Any chance to get this merged? Pretty please :-)

@mhujer
Copy link
Contributor Author

mhujer commented Jun 5, 2019

@lexik bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhujer