Allow caching to be controlled in the config file (and in a more fine-grained way) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-grained way) Add cache_workspaces and cache_windows to the config to individually control what gets cached, but still allow the command-line flag to override the settings and disable the cache entirely. Why? Caching window positions can be a bit unreliable for things like browser windows (which will all have the same WM_CLASS and window title on start-up so may not match between runs/logins when cortile encounters the window).
Most may not need these options so make thier presence in the config file optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there @leukipp - Happy New Year! - I'd appreciate it if you'd accept all, or at least part of, this PR!
When starting up from a saved Desktop session:
Caching window positions has been unreliable for things like browser windows (e.g Firefox).
They will all have the same WM_CLASS and window title on start-up, updating multiple times thereafter, so will not match cortile's cached values when it sees them.
This means windows get placed on the wrong workspace, or worse, assumed to be on a workspace they are not so layouts end up with "holes" in them.
Disabling the cache entirely is an option but having the workspace tiling settings, proportions, etc remembered is a really nice feature that I don't want to have to lose.
This PR adds
cache_workspacesandcache_windowsto the config to individually control what gets cached, but still allow the command-line flag to override the settings and disable the cache entirely.There's 2 commits in it: