Update crl-checker to use math/rand/v2, generate RSA keys sometimes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches to math/rand/v2, and adds a bit more randomization while we're here. We randomly generate either an ECDSA or RSA key to ensure we split issuance across all intermediates. The random domain name setup is simplified by using a random Uint32 instead of a byte buffer.
This is a test program, so alerting about math/rand isn't helpful. Plus these days, Go uses chacha8 for math/rand so it's not so bad. Remove some copy-pasted errcheck exclusions
mcpherrinm
changed the title
jcjones
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to math/rand/v2, and adds a bit more randomization while we're here.
We randomly generate either an ECDSA or RSA key to ensure we split issuance across all intermediates.
The random domain name setup is simplified by using a random Uint32 instead of a byte buffer.