Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: commute BitVec.extractLsb(')? with BitVec.{and,not} #6747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: commute BitVec.extractLsb(')? with BitVec.{and,not} #6747

wants to merge 1 commit into from

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Jan 22, 2025 •
edited
Loading

This PR adds the ability to push BitVec.extractLsb and BitVec.extractLsb' into BitVec.and as well as BitVec.not. This is useful for constant-folding extracts.

@bollu
feat: commute BitVec.extractLsb(')? with BitVec.and
9cf84de 
This PR adds the ability to push `BitVec.extractLsb` and `BitVec.extractLsb'` into `BitVec.and`.
This is useful for constant-folding extracts.
@bollu bollu requested a review from kim-em as a code owner January 22, 2025 18:51
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 22, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 6ebce421423445eeac59a6f4347a562897a99e8d --onto 9b74c07767dc50645efa00356a7724e7f7176227. (2025-01-22 19:13:27)

@hargoniX hargoniX added the changelog-library Library label Jan 22, 2025
@bollu bollu changed the title feat: commute BitVec.extractLsb(')? with BitVec.and feat: commute BitVec.extractLsb(')? with BitVec.{and,not} Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bollu @leanprover-community-bot @hargoniX