-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect explicitly inaccessible pattern variables #6558
base: master
Are you sure you want to change the base?
Conversation
Mathlib CI status (docs):
|
@cppio, you can write a comment like |
I pushed the required Mathlib fixes to the It's great when PR authors can do this step themselves too (ask me on zulip if you need write access to Mathlib branches), but also don't hesitate to ask me for help when |
changelog-language |
The mathlib test failure occurs due to it relying on #6570. The following change fixes the test, but I lack the access to push it. def walk.map (f : α → β) (w : walk α x y) : walk β (f x) (f y) :=
- match x, y, w with
- | _, _, .nil n => .nil (f n)
+ match w with
+ | nil x => nil (f x) |
This PR changes the matcher elaboration to keep explicit inaccessible pattern variables inaccessible.
Closes #6557