Add offset_bottom support, test and small fixes #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
vinnysgreen
approved these changes
Sep 19, 2016
|
+1, did not mean to review. |
|
Is there anyone around to merge this? |
|
@leafo are you still maintaining the library? if not, is it possible for you to find someone who will? we really need this option to be merged, waited a long time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for offset_bottom and corresponding test
Also a fix for overscrolling (as in chrome browser)
And a fix for inconsistent behaviour in two.html test *needs to be checked (line 30 in .coffee file)
*please ignore the Makefile change