Fix lockup when downloading clips with metadata #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ScrubN
commented
Nov 28, 2023
•
ScrubN
commented
- Fixes Clips get stuck at 100% - never finish and then when I cancel it, it gives this error. #906
- Fixes Clip downloader won't finish "encoding clip metadata" #905
- Fixes Unable to download clips #895
ScrubN
changed the title
ScrubN
commented
Nov 28, 2023
| @@ -63,7 +63,7 @@ void DownloadProgressHandler(StreamCopyProgress streamProgress) | |||
| TwitchHelper.CreateDirectory(downloadOptions.TempFolder); | |||
| } | |||
|
|
|||
| var tempFile = Path.Combine(downloadOptions.TempFolder, $"clip_{DateTimeOffset.Now.ToUnixTimeMilliseconds()}_{Path.GetRandomFileName()}"); | |||
| var tempFile = Path.Combine(downloadOptions.TempFolder, $"{downloadOptions.Id}_{DateTimeOffset.UtcNow.Ticks}.mp4"); | |||
There was a problem hiding this comment.
Using DateTimeOffset.UtcNow.Ticks instead of DateTimeOffset.UtcNow.ToUnixTimeMilliseconds() is necessary to avoid conflicting names if the same url is pasted more than once in url mass downloader. Yes I could have left the name as it was before, but this name is more friendly to end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.