Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix being unable to lower readable-colors flag in CLI #1147

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix being unable to lower readable-colors flag in CLI #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TwitchDownloaderCLI/Modes/Arguments/ChatRenderArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ internal sealed class ChatRenderArgs : IFileCollisionArgs, ITwitchDownloaderArgs
public bool AlternateMessageBackgrounds { get; set; }

[Option("readable-colors", Default = true, HelpText = "Increases the contrast of usernames against the background or outline color.")]
public bool AdjustUsernameVisibility { get; set; }
public bool? AdjustUsernameVisibility { get; set; }

[Option("offline", Default = false, HelpText = "Render completely offline using only embedded emotes, badges, and bits from the input json.")]
public bool Offline { get; set; }
Expand Down
2 changes: 1 addition & 1 deletion TwitchDownloaderCLI/Modes/RenderChat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ private static ChatRenderOptions GetRenderOptions(ChatRenderArgs inputOptions, F
AccentStrokeScale = inputOptions.ScaleAccentStroke,
DisperseCommentOffsets = inputOptions.DisperseCommentOffsets,
AlternateMessageBackgrounds = inputOptions.AlternateMessageBackgrounds,
AdjustUsernameVisibility = inputOptions.AdjustUsernameVisibility,
AdjustUsernameVisibility = (bool)inputOptions.AdjustUsernameVisibility!,
FileCollisionCallback = collisionHandler.HandleCollisionCallback,
};

Expand Down
Loading