Why did I do title translations the dumb way instead of the smart way?

lay295 · Apr 3, 2024 · f843c2c · f843c2c
1 parent 372bc67
commit f843c2c
Show file tree

Hide file tree

Showing 10 changed files with 5 additions and 11 deletions.
diff --git a/TwitchDownloaderWPF/WindowOldVideoCacheManager.xaml b/TwitchDownloaderWPF/WindowOldVideoCacheManager.xaml
@@ -11,7 +11,7 @@
         lex:ResxLocalizationProvider.DefaultAssembly="TwitchDownloaderWPF"
         lex:ResxLocalizationProvider.DefaultDictionary="Strings"
         mc:Ignorable="d"
-        Title="Select Caches To Delete" MinHeight="350" MinWidth="500" Height="450" Width="800" Loaded="OnLoaded" Closing="OnClosing" d:DataContext="{d:DesignInstance local:WindowOldVideoCacheManager}">
+        Title="{lex:Loc TitleWindowOldVideoCacheManager}" MinHeight="350" MinWidth="500" Height="450" Width="800" Loaded="OnLoaded" Closing="OnClosing" d:DataContext="{d:DesignInstance local:WindowOldVideoCacheManager}">
     <Window.Resources>
         <Style TargetType="{x:Type TextBox}" BasedOn="{StaticResource {x:Type TextBox}}">
             <Setter Property="behave:TextBoxTripleClickBehavior.TripleClickSelectLine" Value="True" />

diff --git a/TwitchDownloaderWPF/WindowOldVideoCacheManager.xaml.cs b/TwitchDownloaderWPF/WindowOldVideoCacheManager.xaml.cs
@@ -39,7 +39,6 @@ public WindowOldVideoCacheManager(IEnumerable<DirectoryInfo> directories)
 
         private void OnLoaded(object sender, RoutedEventArgs e)
         {
-            Title = Translations.Strings.TitleWindowOldVideoCacheManager;
             App.RequestTitleBarChange();
 
             // For some stupid reason, this does not work unless I manually set it, even though its a binding

diff --git a/TwitchDownloaderWPF/WindowQueueOptions.xaml b/TwitchDownloaderWPF/WindowQueueOptions.xaml
@@ -10,7 +10,7 @@
         lex:ResxLocalizationProvider.DefaultAssembly="TwitchDownloaderWPF"
         lex:ResxLocalizationProvider.DefaultDictionary="Strings"
         mc:Ignorable="d"
-        Title="Queue Options" MinHeight="280" Height="280" MinWidth="500" Width="500" SizeToContent="WidthAndHeight" Loaded="Window_loaded" Background="{DynamicResource AppBackground}">
+        Title="{lex:Loc TitleEnqueueOptions}" MinHeight="280" Height="280" MinWidth="500" Width="500" SizeToContent="WidthAndHeight" Loaded="Window_loaded" Background="{DynamicResource AppBackground}">
     <Window.Resources>
         <Style TargetType="{x:Type TextBox}" BasedOn="{StaticResource {x:Type TextBox}}">
             <Setter Property="behave:TextBoxTripleClickBehavior.TripleClickSelectLine" Value="True" />

diff --git a/TwitchDownloaderWPF/WindowQueueOptions.xaml.cs b/TwitchDownloaderWPF/WindowQueueOptions.xaml.cs
@@ -684,7 +684,6 @@ private void radioHTML_Checked(object sender, RoutedEventArgs e)
 
         private void Window_loaded(object sender, RoutedEventArgs e)
         {
-            Title = Translations.Strings.TitleEnqueueOptions;
             App.RequestTitleBarChange();
         }
 

diff --git a/TwitchDownloaderWPF/WindowRangeSelect.xaml b/TwitchDownloaderWPF/WindowRangeSelect.xaml
@@ -10,7 +10,7 @@
         lex:ResxLocalizationProvider.DefaultAssembly="TwitchDownloaderWPF"
         lex:ResxLocalizationProvider.DefaultDictionary="Strings"
         mc:Ignorable="d"
-        Title="Select Render Range (Seconds)" Height="150" Width="400" Background="#FFEFEFEF" Initialized="Window_Initialized" Loaded="Window_Loaded">
+        Title="{lex:Loc TitleRenderRange}" Height="150" Width="400" Background="#FFEFEFEF" Initialized="Window_Initialized" Loaded="Window_Loaded">
     <Window.Resources>
         <Style TargetType="{x:Type TextBox}" BasedOn="{StaticResource {x:Type TextBox}}">
             <Setter Property="behave:TextBoxTripleClickBehavior.TripleClickSelectLine" Value="True" />

diff --git a/TwitchDownloaderWPF/WindowRangeSelect.xaml.cs b/TwitchDownloaderWPF/WindowRangeSelect.xaml.cs
@@ -77,7 +77,6 @@ private void numEnd_TextChanged(object sender, TextChangedEventArgs e)
 
         private void Window_Loaded(object sender, RoutedEventArgs e)
         {
-            Title = Translations.Strings.TitleRenderRange;
             App.RequestTitleBarChange();
         }
     }

diff --git a/TwitchDownloaderWPF/WindowSettings.xaml b/TwitchDownloaderWPF/WindowSettings.xaml
@@ -12,7 +12,7 @@
         xmlns:hc="https://handyorg.github.io/handycontrol"
         xmlns:fa="http://schemas.fontawesome.com/icons/"
         mc:Ignorable="d"
-        Title="Global Settings" MinWidth="400" MinHeight="500" Width="500" Height="592" SizeToContent="Height" Initialized="Window_Initialized" Closing="Window_Closing" Loaded="Window_Loaded" Background="{DynamicResource AppBackground}">
+        Title="{lex:Loc TitleGlobalSettings}" MinWidth="400" MinHeight="500" Width="500" Height="592" SizeToContent="Height" Initialized="Window_Initialized" Closing="Window_Closing" Loaded="Window_Loaded" Background="{DynamicResource AppBackground}">
     <Window.Resources>
         <Style TargetType="{x:Type TextBox}" BasedOn="{StaticResource {x:Type TextBox}}">
             <Setter Property="behave:TextBoxTripleClickBehavior.TripleClickSelectLine" Value="True" />

diff --git a/TwitchDownloaderWPF/WindowSettings.xaml.cs b/TwitchDownloaderWPF/WindowSettings.xaml.cs
@@ -130,7 +130,6 @@ private void BtnClearCache_Click(object sender, RoutedEventArgs e)
 
         private void Window_Loaded(object sender, RoutedEventArgs e)
         {
-            Title = Translations.Strings.TitleGlobalSettings;
             App.RequestTitleBarChange();
         }
 
@@ -191,7 +190,6 @@ private void ComboLocale_OnSelectionChanged(object sender, SelectionChangedEvent
                 _refreshCultureOnCancel = true;
                 Settings.Default.GuiCulture = selectedCulture;
                 App.RequestCultureChange();
-                Title = Translations.Strings.TitleGlobalSettings;
             }
         }
 

diff --git a/TwitchDownloaderWPF/WindowUrlList.xaml b/TwitchDownloaderWPF/WindowUrlList.xaml
@@ -10,7 +10,7 @@
         lex:ResxLocalizationProvider.DefaultAssembly="TwitchDownloaderWPF"
         lex:ResxLocalizationProvider.DefaultDictionary="Strings"
         mc:Ignorable="d"
-        Title="Mass Download URL List" MinHeight="590" Height="600" MinWidth="485" Width="500" Loaded="Window_Loaded">
+        Title="{lex:Loc TitleUrlList}" MinHeight="590" Height="600" MinWidth="485" Width="500" Loaded="Window_Loaded">
     <Window.Resources>
         <Style TargetType="{x:Type TextBox}" BasedOn="{StaticResource {x:Type TextBox}}">
             <Setter Property="behave:TextBoxTripleClickBehavior.TripleClickSelectLine" Value="True" />

diff --git a/TwitchDownloaderWPF/WindowUrlList.xaml.cs b/TwitchDownloaderWPF/WindowUrlList.xaml.cs
@@ -169,7 +169,6 @@ private async void btnQueue_Click(object sender, RoutedEventArgs e)
 
         private void Window_Loaded(object sender, RoutedEventArgs e)
         {
-            Title = Translations.Strings.TitleUrlList;
             App.RequestTitleBarChange();
         }
     }
-Original file line number
+Diff line change
@@ Expand Up @@
             private void Window_loaded(object sender, RoutedEventArgs e)
             {
-                Title = Translations.Strings.TitleEnqueueOptions;
                 App.RequestTitleBarChange();
             }
@@ Expand Down @@