Implement wifi no-download alert #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxBlitz
reviewed
Jun 2, 2022
| @@ -64,7 +65,19 @@ const AllLessons = ({route}: {route: any}) => { | |||
| }, | |||
| { | |||
| text: 'OK', | |||
| onPress: () => { | |||
| onPress: async() => { | |||
|
|
|||
|
|
||
| const [wifiOnly, network] = await Promise.all([ | ||
| genPreferenceDownloadOnlyOnWifi(), | ||
| NetInfo.fetch() |
|
|
||
| if (wifiOnly && network.type !== 'wifi') { | ||
| Alert.alert(`You\'re not currently connected to wi-fi, and your preferences don\'t allow downloads over data. | ||
| \nPlease go to your Language Transfer settings and disable "Download Only on wi-fi" to continue.`); |
There was a problem hiding this comment.
let's put '\n' on the prev line
Comment on lines
103
to
112
| const [wifiOnly, network] = await Promise.all([ | ||
| genPreferenceDownloadOnlyOnWifi(), | ||
| NetInfo.fetch() | ||
| ]); | ||
|
|
||
| if (wifiOnly && network.type !== 'wifi') { | ||
| Alert.alert(`You\'re not currently connected to wi-fi, and your preferences don\'t allow downloads over data. | ||
| \nPlease go to your Language Transfer settings and disable "Download Only on wi-fi" to continue.`); | ||
| return; | ||
| } |
There was a problem hiding this comment.
dedup the entire block, put it somewhere vaguely in js/
| if (wifiOnly && network.type !== 'wifi') { | ||
| Alert.alert(`You\'re not currently connected to wi-fi, and your preferences don\'t allow downloads over data. | ||
| \nPlease go to your Language Transfer settings and disable "Download Only on wi-fi" to continue.`); | ||
| return; |
There was a problem hiding this comment.
let's not return. and workshop the copy a bit
| ]); | ||
|
|
||
| if (wifiOnly && network.type !== 'wifi') { | ||
| Alert.alert(`You\'re not currently connected to wi-fi, and your preferences don\'t allow downloads over data. |
There was a problem hiding this comment.
don't think you need backslashes here
jafayer
force-pushed
the
warn-when-mobile-data
branch
from
01e4b8c to
76b1538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issues: clicking "download all" will initialize n notifications and probably crash the app.