Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(groq): Fix Max Retries for Groq #7481

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

weakit
Copy link
Contributor

@weakit weakit commented Jan 8, 2025

The maxRetries field is not respected with the Groq integration. This PR fixes this issue.

By default, the Groq SDK automatically retries any request twice.
So with a default of 6 max retries, this results in 6 * 3 = 18 API calls before the request fails, or is passed on to a fallback provider.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 8, 2025
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jan 8, 2025 8:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jan 8, 2025 8:18am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jan 8, 2025
@jacoblee93
Copy link
Collaborator

Thank you - nice catch!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Jan 8, 2025
@jacoblee93 jacoblee93 changed the title Fix Max Retries for Groq fix(groq): Fix Max Retries for Groq Jan 8, 2025
@jacoblee93 jacoblee93 merged commit 67e00e0 into langchain-ai:main Jan 9, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants