feat(google-common): Gemini logprobs #7472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
afirstenberg
changed the title
dosubot
bot
added
auto:documentation
jacoblee93
reviewed
Jan 9, 2025
| @@ -189,8 +189,16 @@ export abstract class ChatGoogleBase<AuthOptions> | |||
|
|
|||
| topK = 40; | |||
|
|
|||
| presencePenalty = undefined; | |||
There was a problem hiding this comment.
Don't need to init as undefined - should have their actual typing
jacoblee93
reviewed
Jan 9, 2025
| stopSequences: string[] = []; | ||
|
|
||
| logprobs: false; |
There was a problem hiding this comment.
This means that the only acceptable value is false
Did you mean to set logprobs = false?
and topLogprobs = 0?
There was a problem hiding this comment.
Doh! Yeah. Thanks for catching this.
jacoblee93
reviewed
Jan 9, 2025
| const topTokens: GeminiLogprobsTopCandidate[] = | ||
| logprobs?.topCandidates ?? []; | ||
| const content: Logprob[] = []; | ||
| for (let co = 0; co < chosenTokens.length; co += 1) { |
There was a problem hiding this comment.
nit: what does co mean?
There was a problem hiding this comment.
Counter. (Throwback to my BASIC days.)
|
Fixed the type declarations. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for OpenAI compatible logprobs, including:
response_metadatain the same format OpenAI usesAdd support for token selection updates in model parameters:
Added tests for same.