Rremove all application connector helm charts as they are managed now in the Application Connector module #18367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for kyma-project pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kyma-bot
added
the
size/XL
4 tasks
grego952
previously approved these changes
Oct 27, 2023
grego952
approved these changes
Nov 3, 2023
ruanxin
approved these changes
Nov 6, 2023
a-thaler
requested changes
Nov 6, 2023
There was a problem hiding this comment.
The PR has no description at all, hard to review without proper context.
There is a CRD applications.applicationconnector.crd in the compass-agent folder, is that related and could be removed?
What is with dopcumentation, the docs folder contains a section about application connectivity
a-thaler
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This purpose of the PR is a cleanup of Kyma charts after initial modularisation of of
application-connectorKyma component.We remove helm charts and all dependent Kubernetes objects of following components:
They are now fully migrated and located in the new module in application-connector-manager repository.
Application connector specific objects
Istio dependencies
Additionally application-connector is removed from Kyma installation configuration.
The PR to remove related legacy documentation from Kyma repo can be found here
Additional information:
The last part of application connectivity area -
compass-runtime-agentservice charts must remain in Kyma repo for some time because of required changes to KCP.After deployment of new compass-manager service,
compass-runtime agentwill be included into application-connector modules and its charts will be removed from Kyma repo as well.