Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance data sanitizer to remove last-applied-configuration #357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muralov
Copy link
Collaborator

@muralov muralov commented Jan 23, 2025

Enhance data sanitizer to remove last-applied-configuration

  • Implemented _remove_last_applied_configuration method to delete the kubectl.kubernetes.io/last-applied-configuration annotation from Kubernetes resource objects.
  • Added unit tests to verify the removal of the last-applied-configuration annotation from Deployment resources.

- Implemented _remove_last_applied_configuration method to delete the kubectl.kubernetes.io/last-applied-configuration annotation from Kubernetes resource objects.
- Added unit tests to verify the removal of the last-applied-configuration annotation from Deployment resources.
@muralov muralov requested a review from a team as a code owner January 23, 2025 15:43
@muralov muralov requested a review from mfaizanse January 23, 2025 15:43
Copy link

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants