Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extend Redis checkpointing unit tests #351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: extend Redis checkpointing unit tests #351

wants to merge 1 commit into from

Conversation

muralov
Copy link
Collaborator

@muralov muralov commented Jan 22, 2025

Extend Redis checkpointing tests

  • Refactor and expand unit tests for Redis checkpointing functions to cover various edge cases and improve test coverage.
  • Add detailed docstrings and parameterized tests for better clarity and maintainability.

@muralov muralov requested a review from a team as a code owner January 22, 2025 18:43
@muralov muralov requested review from friedrichwilken and tanweersalah and removed request for friedrichwilken January 22, 2025 18:43
@github-actions GitHub Actions
Copy link

Note(s) for PR Auther:

  • The integration test will be skipped for the PR. You can trigger it manually after adding the label: run-integration-test.
  • The evaluation test will be skipped for the PR. You can trigger it manually after adding the label: evaluation requested.
  • If any changes are made to the evaluation tests data, make sure that the integration tests are working as expected.
  • If any changes are made to how to run the unit tests, make sure to update the steps for unit-tests in the create-release.yml workflow as well.

Note(s) for PR Reviewer(s):

  • Make sure that the integration and evaluation tests are working as expected.

@muralov
chore: update dependencies and enhance Redis checkpointing tests
55d92e7 
- Refactor and expand unit tests for Redis checkpointing functions to cover various edge cases and improve test coverage.
- Add detailed docstrings and parameterized tests for better clarity and maintainability.
@muralov muralov force-pushed the add-tests-redis-checkpointer-keys branch from 7588a1d to 55d92e7 Compare January 23, 2025 15:46
@tanweersalah tanweersalah added evaluation requested A PR with this label will trigger the validation workflow. run-integration-test labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanweersalah tanweersalah Awaiting requested review from tanweersalah

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: yes evaluation requested A PR with this label will trigger the validation workflow. run-integration-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muralov @tanweersalah @kyma-bot