Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: module delete should work with old module templates #2326

Merged
merged 6 commits into from
Jan 23, 2025
Merged

fix: module delete should work with old module templates #2326

merged 6 commits into from
Jan 23, 2025

Conversation

halamix2
Copy link
Member

@halamix2 halamix2 commented Jan 21, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • module delete should work with old module templates, by looking up modules by the ModuleTemplate name of noduleName-channel
  • module delete should work with new module templates, by looking up modules by the ModuleReleaseMeta and associated ModuleTemplate

Related issue(s)

@halamix2 halamix2 requested a review from a team as a code owner January 21, 2025 09:41
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2025
@halamix2 halamix2 force-pushed the module-delete-old-template branch from 6f8c3a8 to 36413e9 Compare January 21, 2025 10:43
@halamix2 halamix2 enabled auto-merge (squash) January 21, 2025 10:51
@halamix2 halamix2 disabled auto-merge January 22, 2025 07:46
@halamix2 halamix2 self-assigned this Jan 22, 2025
@halamix2 halamix2 force-pushed the module-delete-old-template branch from b399170 to 6aac520 Compare January 22, 2025 08:53
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2025
@halamix2 halamix2 force-pushed the module-delete-old-template branch from 2275755 to a28380d Compare January 22, 2025 13:10
@halamix2 halamix2 removed their assignment Jan 23, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2025
@halamix2 halamix2 merged commit 99785db into kyma-project:main Jan 23, 2025
4 checks passed
@halamix2 halamix2 deleted the module-delete-old-template branch January 23, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pPrecel pPrecel pPrecel approved these changes

Assignees

@pPrecel pPrecel

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halamix2 @pPrecel @kyma-bot