Add pause button #14
Open
Add pause button #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raising the targetSdkVersion means the ActivityBar had to be ported. Done that. In order to not make things extra convoluted in this new scenario, switching the content within an activity does not look like a good idea, so I had to refactor a bit, making this patch rather larger.
|
Updates:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first venture into Android programming, please bear with me. I'm aware this PR will need more work. It is composed of two commits:
2a) Add a Pause/Resume button to the Run/Rest/Break screens. See issue Provide a "pause" button #8 .
2b) Do not auto-pause on loss of focus. See issue Time stops when screen off or app not on focus #3 . I am aware this may be somewhat controversial, and should probably be controlled by a setting. Anyway, before putting more work into detail, I wanted to present what I have so far for some initial feedback on whether this may be of interest.