-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readiness probe docs to match observed behaviour #49476
base: main
Are you sure you want to change the base?
Update readiness probe docs to match observed behaviour #49476
Conversation
Welcome @NovemberZulu! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/sig docs |
Description
This PR updates documentation about readiness probes to explicitly state that pods that are being terminating (i.e.
.metadata.deletionTimestamp
is set) still haveReady
condition"True"
and.status.Phase == "Running"
. I kept the exiting text, but looking athttps://github.com/kubernetes/kubernetes/blob/f64b651ebae643d422f4625161dc415970e2c166/pkg/kubelet/prober/prober_manager.go#L298 and https://github.com/kubernetes/kubernetes/blob/f64b651ebae643d422f4625161dc415970e2c166/pkg/kubelet/prober/prober_manager.go#L339
https://github.com/kubernetes/kubernetes/blob/f64b651ebae643d422f4625161dc415970e2c166/pkg/kubelet/prober/worker.go#L259
I'd say that liveness probes are processed the same way no matter is the pod is terminating or not. Please advice if we should rephrase the note more, or remove it entirely. Thank you!