Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-builder: add optional job to test workload ID auth #32986

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

mboersma
Copy link
Contributor

Adds a new, optional pull-azure-vhds-wi job for the sig-cluster-lifecycle image-builder project. This will enable us to test and iterate on changes necessary to move this job to community testing infrastructure ASAP.

See also kubernetes-sigs/image-builder#1508

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 15, 2024
@mboersma
Copy link
Contributor Author

/cc @jsturtevant @nawazkh

@mboersma mboersma force-pushed the image-builder-workload-id branch from 10c8f2b to fdc34a6 Compare July 15, 2024 19:36
@mboersma
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@mboersma mboersma force-pushed the image-builder-workload-id branch from fdc34a6 to 65ff0dd Compare July 15, 2024 19:58
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2024
@mboersma mboersma force-pushed the image-builder-workload-id branch from 65ff0dd to fdc34a6 Compare July 15, 2024 20:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2024
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma, willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma
Copy link
Contributor Author

/hold cancel

Here goes nothing.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3864363 into kubernetes:master Jul 15, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@mboersma: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key image-builder-presubmits.yaml using file config/jobs/kubernetes-sigs/image-builder/image-builder-presubmits.yaml

In response to this:

Adds a new, optional pull-azure-vhds-wi job for the sig-cluster-lifecycle image-builder project. This will enable us to test and iterate on changes necessary to move this job to community testing infrastructure ASAP.

See also kubernetes-sigs/image-builder#1508

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma mboersma deleted the image-builder-workload-id branch July 15, 2024 20:55
@nawazkh
Copy link
Contributor

nawazkh commented Jul 15, 2024

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants