Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replenish e2e test for kubelet instance config #3139

Merged
merged 1 commit into from
Dec 30, 2024
Merged

replenish e2e test for kubelet instance config #3139

merged 1 commit into from
Dec 30, 2024

Conversation

HirazawaUi
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kinder Issues to track work in the kinder tool labels Dec 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 29, 2024
@HirazawaUi
Copy link
Contributor Author

The test works fine in my local test environment

Deleting cluster "kinder-instance-config" ...
 completed!

Ran 20 of 20 tasks in 0.000 seconds
SUCCESS! -- 20 tasks Passed | 0 Failed | 0 Skipped

see junit-runner.xml and task logs files for more details

neolit123
neolit123 reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit about task name but LGTM

kinder/ci/tools/update-workflows/templates/workflows/instance-config-tasks.yaml Outdated
@@ -218,6 +218,36 @@ tasks:
exit 1;
}
exit 0
timeout: 5m
- name: check-and-add-kubeadm-flags
Copy link
Member

@neolit123 neolit123 Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: check-and-add-kubeadm-flags
- name: check-and-add-flag

(since there is only one 'flag' we care about in the tasks, and later tasks are also named just 'flag')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Copy link
Member

@neolit123 neolit123 Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i recommended flag not flags.
in follow up tasks you have check-flag-after-second-upgrade.

just try making the naming consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your carefulness, fixed again.

@HirazawaUi HirazawaUi force-pushed the rep-instance-config-tests branch from fd5ac98 to 2dcd39d Compare December 30, 2024 11:13
@HirazawaUi HirazawaUi force-pushed the rep-instance-config-tests branch from 2dcd39d to d227d40 Compare December 30, 2024 14:49
neolit123
neolit123 reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit cfc3ba8 into kubernetes:main Dec 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kinder Issues to track work in the kinder tool cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HirazawaUi @k8s-ci-robot @neolit123