Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/controller-runtime from 0.19.4 to 0.20.0 #12723

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps sigs.k8s.io/controller-runtime from 0.19.4 to 0.20.0.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.20.0

Highlights

  • Based on k8s.io/* v1.32 libraries and minimum Go version is now v1.23
  • New experimental priority queue feature
    • More details in #3013 and #2374
    • Can be enabled via manager.Options.Controller.UsePriorityQueue
    • Please give it a try and provide feedback in #2374
  • AggregatedDiscovery is automatically used when available (#2901)
  • As usual, many improvements to the fake client

Changes since v0.19.0

⚠️ Breaking Changes

  • Bump to k8s.io/* v1.32 libraries (#2971 #2990 #3001 #3007 #3029 #3043)
  • logging: Stop deduplicating API warnings by default (#2953)
  • webhook: Stop deleting unknown fields in CustomDefaulter (#2982 #3056)
  • webhook: Remove deprecated Defaulter and Validator (#2877 #2945)
  • cluster: Remove deprecated SyncPeriod option (#2970)

✨ New Features

  • cache: Add EnableWatchBookmarks option (defaults to true) (#3017)
  • cache: Export NewInformer option (#3061)
  • cert-watcher: Add polling (#3020 #3050)
  • controller: Add experimental priority queue (off per default) (#3013 #3014 #3060 #3066)
  • fake client: Allow adding indexes at runtime (#3021)
  • fake client: Add support for ServiceAccountToken subresource (#2969)
  • restmapper: Use AggregatedDiscovery if available (#2901)
  • util: Add HasOwnerReference func (#2882)
  • webhook: Add custom path option (#2998)

🐛 Bug Fixes

  • controller: Error when source.Start() never returns (#2997 #3006 #3008)
  • fake client: Don't return items on invalid selector (#3022)
  • fake client: Fix TOCTOU races (#2980)
  • fake client: Preserve TypeMeta during Get call with PartialObjectMeta (#2949)
  • fake client: Preserve TypeMeta during List call with UnstructuredList (#3074)
  • manager: Fix RenewDeadline typo in leader election (#3032)
  • manager: Use leader elector with client timeout (#3028 #3034)

🌱 Others

  • cache: Switch to Go 1.23+ stdlib maps/slices packages (#3012)
  • controller: Log the syncing source when WaitForSync fails (#3016)
  • setup-envtest: drop support for GCS (#2915)
  • Some fixes for typos (#3011 #3033 #2993)

... (truncated)

Commits
  • 8f7e114 Merge pull request #3074 from sbueringer/pr-fix-fake-list
  • 3b23354 fake client: preserve TypeMeta during List call with UnstructuredList
  • 1ec7c1b Merge pull request #3069 from kubernetes-sigs/dependabot/github_actions/all-g...
  • 189b6d8 🌱 Bump the all-github-actions group across 1 directory with 3 updates
  • d19d76c Merge pull request #3066 from alvaroaleman/fix-wow
  • e667a8f 🐛 Fix a bug in the priorityqueue metrics
  • 1de5a3e Merge pull request #3062 from ranakan19/cache_options
  • 2484715 Merge pull request #3064 from alvaroaleman/remove-gosec
  • 3b0b995 🌱 Remove gosec linter
  • c80ea33 Merge pull request #3060 from alvaroaleman/pq-2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2025
Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit e90b232
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/678e7117a74ae900081cccf3

Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/kind cleanup
/priority backlog
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Jan 20, 2025
@Gacko
Copy link
Member

Gacko commented Jan 20, 2025

/cherry-pick release-1.12

@Gacko
Copy link
Member

Gacko commented Jan 20, 2025

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.4 to 0.20.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.20.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.20.0 branch from 63d0c9d to e90b232 Compare January 20, 2025 15:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@Gacko
Copy link
Member

Gacko commented Jan 20, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bacee47 into main Jan 20, 2025
33 checks passed
@k8s-ci-robot k8s-ci-robot deleted the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.20.0 branch January 20, 2025 16:42
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #12731

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #12732

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants