Go: Stop using workspace.

[rikatz]

What this PR does / why we need it:

Since we started to use go workspace, contribution workflow got worst and with no gain. The idea of go workspace would be more related to inter modules consumption (eg. controller vs kubewebhook certgen), which is not the fact on ingress-nginx.

As the person who implemented this, I understand this implementation was wrong and not suitable for Ingress NGINX.

This way, I am proposing to remove this feature, as it is not used on ingress-nginx

I recommend not cherry-picking this change, as it is not a bugfix!!

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only
• Other - Developer experience improvement

Which issue/s this PR fixes

How Has This Been Tested?

Just checked everything is still compiling as desired

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	54342ec
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/6786b7c354616000082ed35c

[Gacko]

Do you have any insights if and how tools like Dependabot might need to be adjusted to this change? Or is Dependabot not giving a sh** and just looking for go.mod anyway? Apart from that I really like the idea as the go.work.sum is often modified by tools like VS Code, even though it wouldn't by pure go CLI tooling.

[Gacko]

One thought regarding "not cherry-picking": We are cherry-picking Dependabot PRs. I think these normally also affects the go.work.sum and therefore I'd be a bit afraid of not cherry-picking this as then there's still a go.work.sum on release branches but it's no longer being updated by Dependabot PRs.

[Gacko]

/retitle Go: Stop using workspace.
/triage accepted
/kind cleanup
/priority backlog
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Gacko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

With my comments in mind, I'd be happy if it would be ok to cherry-pick these.

[rikatz]

I wouldn't. I think as this is not really a bugfix, cherry picks should be kept for bug fixes only but you can try

[rikatz]

About dependabot: it shouldn't matter. Iirc dependabot reads all go.mod from repo and doesn't really care about go.work

[Gacko]

I wouldn't. I think as this is not really a bugfix, cherry picks should be kept for bug fixes only but you can try

That's true, but so are dependency bumps and other developer experience improvements (improvements to CI, GitHub Actions, Cloud Build and so on).

Technically you're right, there's not a lot added value in cherry-picking. But on the other hand it would make it easier to diff branches and as long it's not changing how our "product" works, aka. the API we provide, I'd always cherry-pick such cleanup and chores.

[Gacko]

k, just realized a use case where it makes sense to have this synced: Go updates. The go.work contains a Go version and build is breaking/complaining if this isn't aligned to the modules. So bumping Go on main would always require manually bumping it in the go.work on branches where it still exists.

[Gacko]

/cherry-pick release-1.12

[Gacko]

/cherry-pick release-1.11

[k8s-infra-cherrypick-robot]

@Gacko: new pull request created: #12712

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@Gacko: new pull request created: #12713

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.