Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken OWNER links in sig-etcd README #7799

Conversation

henrybear327
Copy link
Contributor

Fixed active projects' OWNER link only, mainly by changing file name from MAINTAINERS to OWNERS and updating branch name from master to main

Notice that for a repo that doesn't have a MAINTAINER or OWNER file, the link is left as-is, the dbtester repo.

References:

Copy link

linux-foundation-easycla bot commented Mar 25, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: henrybear327 / name: Chun-Hung Tseng (5edd163)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @henrybear327!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @henrybear327. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from ahrtr and jmhbnz March 25, 2024 15:40
@k8s-ci-robot k8s-ci-robot added sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 25, 2024
@henrybear327 henrybear327 force-pushed the henrybear327/fix-broken-links-in-readme branch from 8f0a067 to b6d4499 Compare March 25, 2024 15:43
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @henrybear327

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2024
@ahrtr
Copy link
Member

ahrtr commented Mar 25, 2024

/lgtm
/approve

Thank you!

@ahrtr
Copy link
Member

ahrtr commented Mar 25, 2024

/hold

The workflow fails

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@henrybear327
Copy link
Contributor Author

Sorry, I just realized this README.md file needs to be edited from the sigs.yaml file. On it. Sorry again.

Fixed active projects' OWNER link only, mainly by changing file name 
from MAINTAINERS to OWNERS and updating branch name from master to main.

Notice that for a repo that doesn't have a MAINTAINER or OWNER file, 
the link is left as-is, the `dbtester` repo.

References:
- etcd-io/bbolt#578
@henrybear327 henrybear327 force-pushed the henrybear327/fix-broken-links-in-readme branch from b6d4499 to 5edd163 Compare March 25, 2024 15:53
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2024
@henrybear327
Copy link
Contributor Author

henrybear327 commented Mar 25, 2024

Fixed according to the CI error message's suggestion. @ahrtr @jmhbnz

@henrybear327 henrybear327 requested a review from jmhbnz March 25, 2024 16:24
@ahrtr
Copy link
Member

ahrtr commented Mar 25, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@ahrtr
Copy link
Member

ahrtr commented Mar 25, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2024
@ahrtr
Copy link
Member

ahrtr commented Mar 25, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@ahrtr
Copy link
Member

ahrtr commented Mar 25, 2024

/assign @mrbobbytables

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, cblecker, henrybear327, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit f8e7444 into kubernetes:master Mar 25, 2024
3 checks passed
@henrybear327 henrybear327 deleted the henrybear327/fix-broken-links-in-readme branch March 25, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants