🐛 fix: webhook testEnv

[mateusoliveira43]

Enable conversion webhooks for webhook suite_test.go envtest by using k8s.io/client-go/kubernetes/scheme instead of creating new scheme (this also already done in controller suite_test.go)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mateusoliveira43
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @mateusoliveira43. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Hi @mateusoliveira43,

This one will require a safer approach and a deeper analysis to ensure that these changes are truly necessary and/or the best approach for the default scaffolds.

Currently, we have envtests implemented and everything is functioning correctly, as shown here:
cronjob_webhook_test.go

I don’t believe that webhook tests are heavily used by users at the moment, but that doesn’t seem to be the case for controllers. Additionally, we already have mocks with tests that are functioning correctly for controllers.

Also, we’ve never added the CRDInstallOptions option—it doesn’t seem to be required.

Could we raise an issue explaining why this change is necessary?
Could you provide more detailed information in the description here?

It would be helpful if you could let us know:

• What you tried to do and what didn’t work as expected.
• What challenges you faced and what you expected to see instead that led you to make each change.
  (For example, moving the AddSchemes, removing the import, and adding the optional spec for envtest.)

/hold until we have those details and ensure that each change is required/and or is the best approach for the default scaffolds.

Btw, thanks a lot for looking on that.

[mateusoliveira43]

@camilamacedo86 will undo change to CRDInstallOptions, the default value is what I am adding

// Scheme is used to determine if conversion webhooks should be enabled
// for a particular CRD / object.
//
// Conversion webhooks are going to be enabled if an object in the scheme
// implements Hub and Spoke conversions.
//
// If nil, scheme.Scheme is used.

Will add more info to PR description

[camilamacedo86]

Hi @mateusoliveira43

I think we can reduce the scope of this one
We can have a PR to add the schemas before start the envtest

Then, we can have a PR that propose we remove apimachineryruntime and use scheme.Scheme and explain why we want to do that

[mateusoliveira43]

done #4466

will open next one after that one merges

[camilamacedo86]

HI @mateusoliveira43

Can you rebase it with the master and ensure that you have what was changed and why in the description?

[mateusoliveira43]

@camilamacedo86 updated