Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gen-sdk.sh to generate sdk using docker container #681

Merged
merged 14 commits into from
Jan 17, 2025
Merged

update gen-sdk.sh to generate sdk using docker container #681

merged 14 commits into from
Jan 17, 2025

Conversation

epicseven-cup
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Updates sdk generation using docker container

Which issue(s) this PR fixes:

Fixes #190

Special notes for your reviewer:

This is a draft pr

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 29, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 29, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @epicseven-cup!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @epicseven-cup. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 29, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 29, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset ready!

Name Link
🔨 Latest commit e31006d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/6789da3e4971cf0008ee809f
😎 Deploy Preview https://deploy-preview-681--kubernetes-sigs-jobset.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 29, 2024
@epicseven-cup
Copy link
Contributor Author

Hi sorry for all these message, this is currently a draft pr.

The direction I was going was to just use the openapi tool docker image to generate the sdk within the gen-sdk.sh script.

I will need to up some of the old apt installs and move the generated sdk correctly though feel free to take a look

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2024
@danielvegamyhre
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 29, 2024
@danielvegamyhre
Copy link
Contributor

Hi sorry for all these message, this is currently a draft pr.

The direction I was going was to just use the openapi tool docker image to generate the sdk within the gen-sdk.sh script.

I will need to up some of the old apt installs and move the generated sdk correctly though feel free to take a look

No worries, tag me when it is ready for review or if you have any questions

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2024
@danielvegamyhre danielvegamyhre added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 6, 2024
@kannon92
Copy link
Contributor

kannon92 commented Oct 8, 2024

/hold cancel

I think it won't run tests while being in Draft.

@kannon92
Copy link
Contributor

/test

@k8s-ci-robot
Copy link
Contributor

@kannon92: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-jobset-test-e2e-main-1-28
  • /test pull-jobset-test-e2e-main-1-29
  • /test pull-jobset-test-e2e-main-1-30
  • /test pull-jobset-test-e2e-main-1-31
  • /test pull-jobset-test-integration-main
  • /test pull-jobset-test-unit-main
  • /test pull-jobset-verify-main

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahg-g
Copy link
Contributor

ahg-g commented Dec 9, 2024

Is this PR still relevant?

@epicseven-cup
Copy link
Contributor Author

Is this PR still relevant?

Yup, sorry I hadn't gotten time to submit a PR for the testing image update to include docker. I will get this in by next week

@epicseven-cup epicseven-cup mentioned this pull request Dec 15, 2024
Closed
@epicseven-cup
Copy link
Contributor Author

epicseven-cup commented Dec 15, 2024 •
edited
Loading

I added the pr for image update to include podman (since it requires less changes to the image building process). kubernetes/test-infra#33955

@epicseven-cup epicseven-cup mentioned this pull request Dec 17, 2024
Merged
@epicseven-cup
Copy link
Contributor Author

I made a new pr to enable docker-in-docker for the pull-job-verify-main image, here is the link kubernetes/test-infra#33977

@ahg-g
Copy link
Contributor

ahg-g commented Dec 17, 2024

/retest

1 similar comment
@ahg-g
Copy link
Contributor

ahg-g commented Dec 18, 2024

/retest

ahg-g
ahg-g reviewed Dec 18, 2024
View reviewed changes
hack/python-sdk/gen-sdk.sh Outdated
# echo "Podman is found, changing over to podman"
# CONTAINER_ENGINE=podman
# USERLEVEL=""
#fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please cleanup this code?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2024
@epicseven-cup
Copy link
Contributor Author

Looks like I still need to start the docker daemon within the pull-jobset-verify-main job image, I will check on that as well

@ahg-g
Copy link
Contributor

ahg-g commented Jan 6, 2025

Looks like I still need to start the docker daemon within the pull-jobset-verify-main job image, I will check on that as well

Hi @epicseven-cup , are you able to conclude this PR?

@epicseven-cup
Copy link
Contributor Author

yup! I will start again this weekend

@epicseven-cup
Copy link
Contributor Author

I added the labels here: kubernetes/test-infra#34123

@epicseven-cup
Copy link
Contributor Author

/retest

@epicseven-cup
Copy link
Contributor Author

looks good, on the test

@ahg-g
Copy link
Contributor

ahg-g commented Jan 17, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, epicseven-cup

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 46e6c61 into kubernetes-sigs:main Jan 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@aojea aojea aojea left review comments

@danielvegamyhre danielvegamyhre Awaiting requested review from danielvegamyhre

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python SDK: Install Python and Java from source rather than using package manager
6 participants
@epicseven-cup @k8s-ci-robot @danielvegamyhre @kannon92 @ahg-g @aojea