Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump CAPI to v1.8.8 #337

Merged

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Dec 30, 2024

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.8.8.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2024
@mboersma mboersma changed the title Bump CAPI to v1.8.7 🌱 Bump CAPI to v1.8.7 Dec 30, 2024
@mboersma mboersma force-pushed the bump-capi-one-eight-seven branch from ae4ab10 to 26045fa Compare December 30, 2024 16:47
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@@ -3,31 +3,31 @@ managementClusterName: caaph-e2e
images:
- name: ${MANAGER_IMAGE}
loadBehavior: mustLoad
- name: registry.k8s.io/cluster-api/cluster-api-controller:v1.7.4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently we forgot to bump the e2e test versions of CAPI in previous update PRs. 😮

@mboersma
Copy link
Contributor Author

/assign @Jont828

@mboersma mboersma force-pushed the bump-capi-one-eight-seven branch from 26045fa to ac0b1fd Compare December 30, 2024 19:12
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot changed the title 🌱 Bump CAPI to v1.8.7 Bump CAPI to v1.8.8 Dec 30, 2024
@mboersma mboersma removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@mboersma
Copy link
Contributor Author

/retitle 🌱 Bump CAPI to v1.8.8

@k8s-ci-robot k8s-ci-robot changed the title Bump CAPI to v1.8.8 🌱 Bump CAPI to v1.8.8 Dec 30, 2024
@Jont828
Copy link
Contributor

Jont828 commented Jan 3, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2601bfb into kubernetes-sigs:main Jan 3, 2025
23 of 24 checks passed
@mboersma mboersma deleted the bump-capi-one-eight-seven branch January 3, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants