Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adopt storage package in cloud provider azure #2312

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: adopt storage package in cloud provider azure #2312

merged 1 commit into from
Jan 13, 2025

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Jan 2, 2025 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:
Adopt storage package in cloud provider
Bump k8s.io to 0.32.0
Add license files
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 2, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 2, 2025
andyzhangx
andyzhangx reviewed Jan 6, 2025
View reviewed changes
go.mod Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2025
@MartinForReal MartinForReal force-pushed the shafan/bump branch 3 times, most recently from 828db65 to eca56d5 Compare January 7, 2025 17:32
@MartinForReal MartinForReal marked this pull request as ready for review January 7, 2025 17:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@MartinForReal MartinForReal force-pushed the shafan/bump branch 2 times, most recently from 8221069 to 2cc9659 Compare January 8, 2025 03:17
@MartinForReal MartinForReal changed the title bumpcloudprovider Adopt storage package in cloudprovider-azure Jan 8, 2025
@MartinForReal MartinForReal force-pushed the shafan/bump branch 3 times, most recently from 19a3761 to 9adf2f0 Compare January 8, 2025 04:54
@andyzhangx
Copy link
Member

/retest

1 similar comment
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/test pull-azurefile-csi-driver-sanity

andyzhangx
andyzhangx reviewed Jan 8, 2025
View reviewed changes
pkg/azurefile/azurefile_dataplane_client.go
@@ -47,7 +46,7 @@ type azureFileDataplaneClient struct {
*service.Client
}

func newAzureFileClient(accountName, accountKey, storageEndpointSuffix string, backoff *retry.Backoff) (azureFileClient, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backoff is necessary here, otherwise you would get the

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the reason why sanity test failed

@andyzhangx
Copy link
Member 

GRPC error: rpc error: code = Internal desc = failed to create VHD disk: Put "https://f03856e3ec57145f69c28c1.core.windows.net/pvcd-8e06e85a-ed0c-48f4-88ac-6d02d5d11ade/pvcd-8e06e85a-ed0c-48f4-88ac-6d02d5d11ade.vhd": dial tcp: lookup f03856e3ec57145f69c28c1.core.windows.net on 168.63.129.16:53: no such host

I think you are missing file in https://f03856e3ec57145f69c28c1.core.windows.net, it should be https://f03856e3ec57145f69c28c1.file.core.windows.net

@MartinForReal
Copy link
Contributor Author

/test pull-azurefile-csi-driver-sanity

@MartinForReal MartinForReal force-pushed the shafan/bump branch 4 times, most recently from 237c8fe to a295afe Compare January 9, 2025 04:08
@MartinForReal
Copy link
Contributor Author

/retest

@andyzhangx
Copy link
Member

image build issue would be fixed by #2335

@andyzhangx
Copy link
Member

/retest

@andyzhangx andyzhangx changed the title Adopt storage package in cloudprovider-azure chore: adopt storage package in cloud provider azure Jan 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@MartinForReal
adopt storage package in cloud provider
1f5ec17 
bump k8s.io to 0.32.0
add license files

Signed-off-by: MartinForReal <[email protected]>
andyzhangx
andyzhangx approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@andyzhangx andyzhangx merged commit 0ab46a6 into kubernetes-sigs:master Jan 13, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@cvvz cvvz Awaiting requested review from cvvz

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinForReal @k8s-ci-robot @andyzhangx