Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Provisioned v2 Azure File share sku #2142

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Oct 17, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support Provisioned v2 Azure File share sku

https://learn.microsoft.com/en-us/azure/storage/files/understanding-billing#provisioned-v2-model

v2 is not supported on all regions

RESPONSE 400: 400 Bad Request
ERROR CODE: RedundancyConfigurationNotAvailableInRegion
--------------------------------------------------------------------------------
{
  "error": {
    "code": "RedundancyConfigurationNotAvailableInRegion",
    "message": "The storage account failed to create due to redundancy configuration - Sku: StandardV2_LRS, Kind: FileStorage - not available in selected Region - switzerlandnorth. Please make sure the redundancy configuration selected is available in your region. For more information about redundancy configurations, see https://docs.microsoft.com/en-us/azure/storage/common/storage-redundancy"
  }

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: support Provisioned v2 Azure File share sku

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2024
@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied October 17, 2024 02:20
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2024
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@andyzhangx andyzhangx force-pushed the upgrade-sa-api-version branch from 85d720d to 3916543 Compare January 17, 2025 14:08
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2025
@andyzhangx andyzhangx changed the title vendor: upgrade storage account api-version as 2023-05-01 feat: support Provisioned v2 Azure File share sku Jan 17, 2025
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx force-pushed the upgrade-sa-api-version branch from 3916543 to eba1c7d Compare January 18, 2025 02:31
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 18, 2025

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-capz-windows-2022 85d720d link true /test pull-azurefile-csi-driver-e2e-capz-windows-2022
pull-azurefile-csi-driver-external-e2e-nfs eba1c7d link true /test pull-azurefile-csi-driver-external-e2e-nfs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit ef8322c into master Jan 18, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants