Refactor Controller Test #585

Kartik494 · 2021-03-12T11:24:35Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #376

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Kartik494 · 2021-03-12T11:24:45Z

/hold

k8s-ci-robot · 2021-03-12T11:24:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kartik494
To complete the pull request process, please assign saad-ali after the PR has been reviewed.
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Kartik494 · 2021-04-29T11:11:58Z

pkg/controller/controller_test.go

@@ -3114,6 +3100,35 @@ func TestProvisionFromSnapshot(t *testing.T) {
 	}
 }

+func (s *testcase) notNilSnapshotStatusTest(notNilSnapshotStatusTest bool) {


Hi @msau42 , i think added a constructor could be useful while i changing removing if-else statement and using a method instead. i am facing error when fetching expectedpvSpec property from testcase struct.

msau42 · 2021-05-12T00:04:01Z

/assign @mauriciopoppe
Mauricio, can you help take a look?

mauriciopoppe · 2021-05-12T00:49:33Z

pkg/controller/controller_test.go

 		t.Run(k, func(t *testing.T) {
-			runFSTypeProvisionTest(t, k, tc, requestedBytes, driverName, "" /* no migration */)
+			runFSTypeProvisionTest(t)


for every k, testcase := range testcase we're trying to test testcase however I don't see any reference to it here

mauriciopoppe · 2021-05-12T00:52:58Z

pkg/controller/controller_test.go

@@ -2190,7 +2194,12 @@ func runFSTypeProvisionTest(t *testing.T, k string, tc provisioningFSTypeTestcas
 	}
 }

-func runProvisionTest(t *testing.T, tc provisioningTestcase, requestedBytes int64, provisionDriverName, supportsMigrationFromInTreePluginName string, testProvision bool) {
+func runProvisionTest(t *testing.T) *provisioningTestcase {
+	var k string


all of these local variables aren't set, if set they should be coming from the current testcase

k8s-ci-robot · 2021-08-05T17:52:39Z

@Kartik494: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2021-11-03T18:08:06Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Kartik494 · 2021-11-08T12:09:22Z

/remove-lifecycle stale

pohly · 2021-12-08T13:20:03Z

@Kartik494: this needs a rebase. @mauriciopoppe also had some review comments for which I don't see a response.

Kartik494 · 2021-12-08T16:19:34Z

@pohly Sorry for the delay i was busy with some other work. I will update this PR and addressed the comments ASAP.

k8s-ci-robot · 2022-03-07T14:54:38Z

@Kartik494: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-csi-external-provisioner-unit	`6b120cb`	link	`/test pull-kubernetes-csi-external-provisioner-unit`
pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-1-21	`6b120cb`	link	`/test pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-1-21`
pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-1-23	`6b120cb`	link	true	`/test pull-kubernetes-csi-external-provisioner-distributed-on-kubernetes-1-23`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-triage-robot · 2022-06-05T14:59:34Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-07-05T15:09:47Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2022-08-04T16:09:25Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-08-04T16:09:29Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2021

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2021

k8s-ci-robot requested review from msau42 and xing-yang March 12, 2021 11:24

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2021

Kartik494 force-pushed the Refactor_ControllerTests branch from 8177a29 to 204cfdf Compare March 25, 2021 12:09

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 21, 2021

Refactor Controller Test

504b7e0

Kartik494 force-pushed the Refactor_ControllerTests branch from 8d275fb to 504b7e0 Compare April 22, 2021 11:16

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2021

Merge branch 'master' into Refactor_ControllerTests

6b120cb

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2021

Kartik494 commented Apr 29, 2021

View reviewed changes

k8s-ci-robot assigned mauriciopoppe May 12, 2021

mauriciopoppe reviewed May 12, 2021

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2021

k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 3, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 5, 2022

k8s-ci-robot closed this Aug 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Controller Test #585

Refactor Controller Test #585

Kartik494 commented Mar 12, 2021

Kartik494 commented Mar 12, 2021

k8s-ci-robot commented Mar 12, 2021

Kartik494 Apr 29, 2021

msau42 commented May 12, 2021

mauriciopoppe May 12, 2021

mauriciopoppe May 12, 2021

k8s-ci-robot commented Aug 5, 2021

k8s-triage-robot commented Nov 3, 2021

Kartik494 commented Nov 8, 2021

pohly commented Dec 8, 2021

Kartik494 commented Dec 8, 2021

k8s-ci-robot commented Mar 7, 2022

k8s-triage-robot commented Jun 5, 2022

k8s-triage-robot commented Jul 5, 2022

k8s-triage-robot commented Aug 4, 2022

k8s-ci-robot commented Aug 4, 2022

Refactor Controller Test #585

Refactor Controller Test #585

Conversation

Kartik494 commented Mar 12, 2021

Kartik494 commented Mar 12, 2021

k8s-ci-robot commented Mar 12, 2021

Kartik494 Apr 29, 2021

Choose a reason for hiding this comment

msau42 commented May 12, 2021

mauriciopoppe May 12, 2021

Choose a reason for hiding this comment

mauriciopoppe May 12, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 5, 2021

k8s-triage-robot commented Nov 3, 2021

Kartik494 commented Nov 8, 2021

pohly commented Dec 8, 2021

Kartik494 commented Dec 8, 2021

k8s-ci-robot commented Mar 7, 2022

k8s-triage-robot commented Jun 5, 2022

k8s-triage-robot commented Jul 5, 2022

k8s-triage-robot commented Aug 4, 2022

k8s-ci-robot commented Aug 4, 2022