Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ [v2.0] : Fixed Issue #1786 #1908

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

amit-webkul
Copy link
Collaborator

Fixed Issue #1786

@ashishkumar-webkul
Copy link
Collaborator

Checked and Found that the validation message has been updated

https://prnt.sc/erT0e97zqwiI

@@ -25,6 +25,6 @@ public function passes($attribute, $value)
*/
public function message()
{
return trans('core::validation.decimal');
return trans('The field must be a decimal number');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the translations.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation added.

@devansh-webkul devansh-webkul merged commit 0daf1e4 into krayin:2.0 Jan 13, 2025
4 checks passed
@amit-webkul amit-webkul deleted the product-price-validation branch January 13, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants