Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Node.JS/browser globals for node/react configs #23

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

kingston
Copy link
Owner

@kingston kingston commented Jan 8, 2025

No description provided.

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: d22001b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@ktam/lint-react Patch
@ktam/lint-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kingston kingston requested a review from Copilot January 8, 2025 08:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • packages/lint-node/package.json: Language not supported
  • packages/lint-react/package.json: Language not supported
Comments suppressed due to low confidence (2)

.changeset/gorgeous-birds-walk.md:1

  • [nitpick] The changeset file name 'gorgeous-birds-walk.md' is not descriptive. It should follow a consistent naming convention and clearly describe the changes made.
---

.changeset/gorgeous-birds-walk.md:5

  • [nitpick] The description 'Add browser globals when parsing without Typescript' could be more specific. It should mention that it is for the '@ktam/lint-react' package.
Add browser globals when parsing without Typescript

.changeset/red-cheetahs-applaud.md Outdated Show resolved Hide resolved
@kingston kingston merged commit 14c500d into main Jan 8, 2025
2 checks passed
@kingston kingston deleted the kingston/add-globals branch January 8, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant