-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce unit test for non-blocking lifecycle operator mode #3581
Conversation
Signed-off-by: Jay179-sudo <[email protected]>
lifecycle-operator/controllers/lifecycle/keptnappversion/controller_test.go
Show resolved
Hide resolved
Signed-off-by: Jay179-sudo <[email protected]>
lifecycle-operator/controllers/lifecycle/keptnappversion/controller_test.go
Show resolved
Hide resolved
Signed-off-by: Jay179-sudo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
==========================================
+ Coverage 85.28% 85.51% +0.22%
==========================================
Files 167 167
Lines 7414 7414
==========================================
+ Hits 6323 6340 +17
+ Misses 801 789 -12
+ Partials 290 285 -5 see 5 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
lifecycle-operator/controllers/lifecycle/keptnappversion/controller_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jay179-sudo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Description
Added a unit test for the non-blocking lifecycle operator mode.
I used the manifest provided in the docs as the template for the unit test.
Since the non-blocking mode does not introduce any errors in the controller, we can write a unit test with a mock handler that does not return any errors when using the manifest provided in the docs.
Partially Fixes # (#3121)
How to test
Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.
I use the run test option in VSCode to verify that my tests works.
Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide