Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adapt lifecycle-management and observability getting started guides to use KeptnAppContext #2880

Merged
merged 5 commits into from
Jan 29, 2024
Merged

docs: adapt lifecycle-management and observability getting started guides to use KeptnAppContext #2880

merged 5 commits into from
Jan 29, 2024

Conversation

odubajDT
Copy link
Contributor

Fixes: #2815

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 25, 2024
@odubajDT odubajDT marked this pull request as ready for review January 26, 2024 06:24
@odubajDT odubajDT requested review from a team as code owners January 26, 2024 06:24
@github-actions github-actions bot added the ops label Jan 26, 2024
@odubajDT odubajDT changed the title docs: adapt lifecycle-mamagement and observability getting started guides to consider KeptnAppContext docs: adapt lifecycle-mamagement and observability getting started guides to use KeptnAppContext Jan 26, 2024
@odubajDT odubajDT requested a review from StackScribe January 29, 2024 06:02
StackScribe
StackScribe reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there changes to crd-reference/app.md in this PR when it's specified in a separate issue (#2836)? I have a separate PR for this (#2894). And yes, I really DO understand why, as a writer, you want to do this ;-)

@odubajDT
Copy link
Contributor Author

Why are there changes to crd-reference/app.md in this PR when it's specified in a separate issue (#2836)? I have a separate PR for this (#2894). And yes, I really DO understand why, as a writer, you want to do this ;-)

Ah sorry I wasn't aware that this change is part of a different issue, will revert it

@odubajDT odubajDT mentioned this pull request Jan 29, 2024
Closed
@mowies mowies changed the title docs: adapt lifecycle-mamagement and observability getting started guides to use KeptnAppContext docs: adapt lifecycle-management and observability getting started guides to use KeptnAppContext Jan 29, 2024
@StackScribe
Copy link
Contributor

The "What's next" section should have links to the relevant guides rather than just a statement about what Keptn can do. But that is not part of this ticket so let's do it later, after the guides are updated.

StackScribe
StackScribe previously approved these changes Jan 29, 2024
View reviewed changes
@odubajDT
cleanup spell checker
73de8b1 
Signed-off-by: odubajDT <[email protected]>
@github-actions github-actions bot removed the ops label Jan 29, 2024
@odubajDT
fix taskdefinition
1948bb5 
Signed-off-by: odubajDT <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT merged commit f49b65a into keptn:main Jan 29, 2024
11 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
@odubajDT @Vickysomtee
docs: adapt lifecycle-management and observability getting started gu…
d188cad 
…ides to use KeptnAppContext (keptn#2880)

Signed-off-by: odubajDT <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna left review comments

@StackScribe StackScribe StackScribe approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update examples, kubebuilder sample files, getting started guides with new context features
4 participants
@odubajDT @StackScribe @bacherfl @RealAnna