-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: getting started guide - comment KeptnApp reference fields #2296
Conversation
Signed-off-by: Griffin <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the commented out parts, I'd also like to see this be copy-pasteable so add the correct metadata.name
and other fields so that for new users this is effortless.
Hey @agardnerIT, I had a query since, it is already mentioned in the example section so do we really need it again to re-declare the same ?? |
Hey @prakrit55 any updates on this PR ? Thank you! |
hey @odubajDT, I think the ticket needs a proper report whether to be implemented or not, which you can see in the issue discussions |
@prakrit55 I put the issue on hold since the discussion is not resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on hold
closin this since the corresponding issue was closed as not planned |
fixes: #2287