Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: getting started guide - comment KeptnApp reference fields #2296

Closed
wants to merge 1 commit into from

Conversation

prakrit55
Copy link
Member

fixes: #2287

  • added comments on depicted fields

Signed-off-by: Griffin <[email protected]>
@prakrit55 prakrit55 requested review from a team as code owners October 18, 2023 17:08
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit d7376e2
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6530110caa667600083f8334
😎 Deploy Preview https://deploy-preview-2296--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the commented out parts, I'd also like to see this be copy-pasteable so add the correct metadata.name and other fields so that for new users this is effortless.

@prakrit55
Copy link
Member Author

In addition to the commented out parts, I'd also like to see this be copy-pasteable so add the correct metadata.name and other fields so that for new users this is effortless.

Hey @agardnerIT, I had a query since, it is already mentioned in the example section so do we really need it again to re-declare the same ??

@mowies mowies changed the title docs: getting started guide. comment KeptnApp reference fields docs: getting started guide - comment KeptnApp reference fields Oct 25, 2023
@odubajDT
Copy link
Contributor

Hey @prakrit55 any updates on this PR ? Thank you!

@prakrit55
Copy link
Member Author

prakrit55 commented Nov 21, 2023

Hey @prakrit55 any updates on this PR ? Thank you!

hey @odubajDT, I think the ticket needs a proper report whether to be implemented or not, which you can see in the issue discussions

@mowies
Copy link
Member

mowies commented Nov 21, 2023

@prakrit55 I put the issue on hold since the discussion is not resolved

Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on hold

@mowies
Copy link
Member

mowies commented Dec 7, 2023

closin this since the corresponding issue was closed as not planned

@mowies mowies closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting started guide. Pre-complete KeptnApp
4 participants