Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add instructions on how to update a workload #2278

Merged
merged 15 commits into from
Oct 31, 2023
Merged

docs: add instructions on how to update a workload #2278

merged 15 commits into from
Oct 31, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Oct 16, 2023 •
edited
Loading

part of #2273

This PR adds instructions on how to:

  • update an existing workload of a keptnapp
  • add a new workload to an existing keptnapp

@netlify
Copy link

netlify bot commented Oct 16, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 6a20163
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65411283fad24a0008c398de
😎 Deploy Preview https://deploy-preview-2278--keptn-lifecycle-toolkit.netlify.app/docs/implementing/day-2-operations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 16, 2023
StackScribe
StackScribe reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Just a bit of wordsmithing but this is a great addition!

bacherfl and others added 2 commits October 23, 2023 06:38
@bacherfl @StackScribe
Apply suggestions from code review
9a16821 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix linting
f39afac 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl marked this pull request as ready for review October 23, 2023 05:23
@bacherfl bacherfl requested review from a team as code owners October 23, 2023 05:23
@bacherfl
Copy link
Member Author

Nicely done! Just a bit of wordsmithing but this is a great addition!

Thank you for the suggestions! They should all be incorporated into this PR now

odubajDT
odubajDT previously approved these changes Oct 24, 2023
View reviewed changes
mowies
mowies reviewed Oct 25, 2023
View reviewed changes
docs/content/en/docs/implementing/day-2-operations/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/implementing/day-2-operations/_index.md Outdated Show resolved Hide resolved
bacherfl and others added 5 commits October 25, 2023 10:47
@bacherfl @mowies
Apply suggestions from code review
446067f 
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
move yaml snippets into separate asset files
8184cce 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix links
16bac11 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix links
ac32c67 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix yaml lint
44cfe42 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl mentioned this pull request Oct 30, 2023
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit c900772 into keptn:main Oct 31, 2023
14 checks passed
@keptn-bot keptn-bot mentioned this pull request Oct 31, 2023
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe left review comments

@odubajDT odubajDT odubajDT approved these changes

@RealAnna RealAnna RealAnna approved these changes

@mowies mowies mowies approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bacherfl @StackScribe @mowies @RealAnna @odubajDT