This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 290
Runtime API: aggregate block messages | Introduce Starknet OS output #1160
Merged
tdelabro
merged 24 commits into
keep-starknet-strange:l1-l2-messaging
from
m-kus:feat/get-snos-output
Oct 11, 2023
Merged
Runtime API: aggregate block messages | Introduce Starknet OS output #1160
tdelabro
merged 24 commits into
keep-starknet-strange:l1-l2-messaging
from
m-kus:feat/get-snos-output
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kus
changed the title
Get Starknet OS program output
Runtime API: aggregate block messages | Introduce Starknet OS types
Oct 1, 2023
m-kus
changed the title
Runtime API: aggregate block messages | Introduce Starknet OS types
Runtime API: aggregate block messages | Introduce Starknet OS output
Oct 1, 2023
EvolveArt
suggested changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left few comments
tdelabro
reviewed
Oct 2, 2023
@m-kus I merged the other one, you should rebase more probably cherry-pick your commits and push force on this one :) |
tdelabro
suggested changes
Oct 5, 2023
tdelabro
suggested changes
Oct 6, 2023
tdelabro
suggested changes
Oct 9, 2023
tdelabro
suggested changes
Oct 11, 2023
tdelabro
approved these changes
Oct 11, 2023
EvolveArt
approved these changes
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StarknetOsOutput
type was introduced with a binary codec compatible with Solidity contract (tested on mainnet data)Related to #1133
On the client we can get program output roughly as follows: