Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

added sign_message_hash_braavos function #1131

Merged
merged 11 commits into from
Oct 12, 2023

Conversation

tonypony220
Copy link
Contributor

@tonypony220 tonypony220 commented Sep 20, 2023

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature

Resolves: #1077
added function sign deloy tx for braavos

Does this introduce a breaking change?

No

Other information

Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge once we have coverage back in CI

Copy link
Collaborator

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would be great to add more rustdoc/links to understand better the implementation

@tdelabro tdelabro merged commit 85cb726 into keep-starknet-strange:main Oct 12, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: impl a braavos tx signer
3 participants