This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 290
added sign_message_hash_braavos function #1131
Merged
tdelabro
merged 11 commits into
keep-starknet-strange:main
from
tonypony220:braavos_hash
Oct 12, 2023
Merged
added sign_message_hash_braavos function #1131
tdelabro
merged 11 commits into
keep-starknet-strange:main
from
tonypony220:braavos_hash
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvolveArt
reviewed
Sep 20, 2023
EvolveArt
reviewed
Sep 20, 2023
EvolveArt
suggested changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will merge once we have coverage back in CI
tonypony220
force-pushed
the
braavos_hash
branch
from
October 2, 2023 16:29
5734c45
to
4394ad3
Compare
tdelabro
approved these changes
Oct 12, 2023
EvolveArt
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, would be great to add more rustdoc/links to understand better the implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
Resolves: #1077
added function sign deloy tx for braavos
Does this introduce a breaking change?
No
Other information