Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(airflow): Fix incorrect node names #594

Merged
merged 3 commits into from
Mar 5, 2024
Merged

fix(airflow): Fix incorrect node names #594

merged 3 commits into from
Mar 5, 2024

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Mar 4, 2024 •
edited
Loading

Description

Fix #544

Development notes

It was a quick change - reverting the slugify added in #241

Outdated:

I've also switched the e2e tests to use spaceflights-pandas again because astro-airflow-iris had one word node names so this bug wasn't immediately obvious. We switched to astro-airflow-iris because it didn't have kedro-viz in its requirements which was not supporting pydantic v2 but they've just added the v2 support so it should work now.

EDITED TO ADD: Actually, might be worth switching to spaceflights-pandas after the release of kedro-datasets 3.0.0 because the extra dependencies for the datasets - pyarrow is not being installed properly. It's not worth pinning and unpinning pip right now

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@ankatiyar ankatiyar requested review from noklam and DimedS March 4, 2024 16:30
@ankatiyar ankatiyar changed the title fix(airflow): Fix incorrect node names + switch e2e tests to spaceflights-pandas fix(airflow): Fix incorrect node names Mar 4, 2024
@ankatiyar
Revert changes to e2e tests
3eff661 
Signed-off-by: Ankita Katiyar <[email protected]>
merelcht
merelcht approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

DimedS
DimedS approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ankatiyar !

@ankatiyar ankatiyar merged commit fa3d842 into main Mar 5, 2024
18 checks passed
@ankatiyar ankatiyar deleted the fix/airflow-node-names branch March 5, 2024 10:39
tgoelles pushed a commit to tgoelles/kedro-plugins that referenced this pull request Jun 6, 2024
@ankatiyar @tgoelles
fix(airflow): Fix incorrect node names (kedro-org#594)
7e992a0 
* Fix incorrect node names + switch e2e tests to spaceflights-pandas

Signed-off-by: Ankita Katiyar <[email protected]>

* Not switch e2e tests starters for now

Signed-off-by: Ankita Katiyar <[email protected]>

* Revert changes to e2e tests

Signed-off-by: Ankita Katiyar <[email protected]>

---------

Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: tgoelles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@DimedS DimedS DimedS approved these changes

@noklam noklam Awaiting requested review from noklam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kedro-airflow: Incorrect node names in created DAGs
3 participants
@ankatiyar @DimedS @merelcht