Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set SO_REUSEPORT to True on Linux platform #1415

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

0xGosu
Copy link
Contributor

@0xGosu 0xGosu commented Dec 28, 2020

Automatically set SO_REUSEPORT to True on Linux platform. Add a new test case to verify this, skip 1 existing test case which is not valid if SO_REUSEPORT is enable and fix assertion condition on another test case due to warning produced by this feature

This implement change 2 suggested in this issue: #1414

…estcase to verify this, skip 1 existing test case which is not valid if SO_REUSEPORT is enable and fix assertion condition on another testcase due to warning produced by this feature
@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #1415 (1ec09c3) into master (a815fc7) will decrease coverage by 9.15%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
- Coverage   71.77%   62.62%   -9.16%     
==========================================
  Files          30       30              
  Lines        3586     3593       +7     
==========================================
- Hits         2574     2250     -324     
- Misses       1012     1343     +331     
Impacted Files Coverage Δ
tomodachi/transport/http.py 69.88% <75.00%> (-0.77%) ⬇️
tomodachi/transport/aws_sns_sqs.py 26.36% <0.00%> (-40.62%) ⬇️
tomodachi/discovery/aws_sns_registration.py 50.00% <0.00%> (-31.82%) ⬇️
tomodachi/container.py 66.66% <0.00%> (-4.98%) ⬇️
tomodachi/helpers/middleware.py 88.46% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a815fc7...1ec09c3. Read the comment docs.

@kalaspuff kalaspuff merged commit 11c8ddf into kalaspuff:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants